Skip to content

Fix: Remove cursor and selection when author left #249

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
adzialocha merged 1 commit into from
Aug 23, 2026
Merged

Fix: Remove cursor and selection when author left #249

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion reflection-doc/src/document.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -535,7 +535,8 @@ mod imp {
obj,
#[upgrade_or_default]
move |stack_type, _, _| {
// The `loro::UndoManager` holds internal locks, so we can't update the `Document.can_undo/can_redo` property inline
// The `loro::UndoManager` holds internal locks, so we can't update the
// `Document.can_undo/can_redo` property inline
obj.main_context().spawn(clone!(
#[weak]
obj,
Expand Down Expand Up @@ -661,6 +662,12 @@ mod imp {
}
}

pub(super) fn handle_author_left(&self, author: Author) {
// Negative insert cursor position will delete marker in the text-view.
self.obj()
.emit_by_name::<()>("remote-insert-cursor", &[&author, &-1i32, &-1i32]);
}

pub(super) fn subscription(&self) -> Option<Arc<TopicStream<DocumentHandle>>> {
self.subscription.read().unwrap().clone()
}
Expand Down Expand Up @@ -941,6 +948,8 @@ impl TopicSubscription for DocumentHandle {
document.main_context().invoke(move || {
let author = document.authors().add(VerifyingKey(author));
author.set_online(false);

document.imp().handle_author_left(author);
});
}
}
Expand Down
Loading