Skip to content

Use postcard codec instead of CBOR for ephemeral data #250

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
adzialocha merged 1 commit into from
Aug 23, 2026
Merged

Use postcard codec instead of CBOR for ephemeral data #250

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions Cargo.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 1 addition & 0 deletions reflection-doc/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@ hex = "0.4.3"
indexmap = "2.13.0"
loro = "1.13.9"
p2panda-core = "0.7.1"
postcard = { version = "1.1.3", features = ["alloc"] }
rand = "0.10.1"
reflection-node = { path = "../reflection-node" }
serde = { version = "1.0.228", features = ["derive"] }
Expand Down
16 changes: 5 additions & 11 deletions reflection-doc/src/document.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,6 @@ use glib::subclass::{Signal, prelude::*};
use glib::{Properties, clone};
pub use hex::FromHexError;
use loro::{ExportMode, LoroDoc, LoroText, event::Diff};
use p2panda_core::cbor::{decode_cbor, encode_cbor};
use p2panda_core::{self, Topic};
use reflection_node::{TopicStream, TopicSubscription, TopicSubscriptionError};
use tracing::error;
Expand Down Expand Up @@ -98,14 +97,9 @@ impl DocumentId {
}

#[derive(Debug, serde::Serialize, serde::Deserialize)]
#[serde(tag = "t", content = "d")]
enum EphemeralData {
#[serde(rename = "cursor")]
Cursor {
#[serde(rename = "i")]
insert_cursor: Option<loro::cursor::Cursor>,

#[serde(rename = "s")]
selection_bound: Option<loro::cursor::Cursor>,
},
}
Expand Down Expand Up @@ -290,17 +284,17 @@ mod imp {
*self.insert_cursor.write().unwrap() = insert_cursor;

if send {
self.brodcast_ephemeral();
self.broadcast_ephemeral();
}
}

pub fn brodcast_ephemeral(&self) {
pub fn broadcast_ephemeral(&self) {
let cursor_data = EphemeralData::Cursor {
insert_cursor: self.insert_cursor.read().unwrap().clone(),
selection_bound: self.selection_bound.read().unwrap().clone(),
};

let cursor_bytes = match encode_cbor(&cursor_data) {
let cursor_bytes = match postcard::to_allocvec(&cursor_data) {
Ok(data) => data,
Err(error) => {
error!("Failed to serialize cursor: {}", error);
Expand Down Expand Up @@ -943,7 +937,7 @@ impl TopicSubscription for DocumentHandle {
let author = document.authors().add(VerifyingKey(author));
author.set_online(true);
// When a new author joins we need to send ephemeral messages again
document.imp().brodcast_ephemeral();
document.imp().broadcast_ephemeral();
});
}
}
Expand All @@ -967,7 +961,7 @@ impl TopicSubscription for DocumentHandle {
) {
if let Some(document) = self.0.upgrade() {
document.main_context().invoke(move || {
if let Ok(data) = decode_cbor(&data[..])
if let Ok(data) = postcard::from_bytes(&data[..])
&& let Some(author) = document.authors().author(&VerifyingKey(author))
{
document
Expand Down
Loading