PAB-66: fix piped interactive installs - #36
Merged
Merged
Conversation
Co-authored-by: multica-agent <github@multica.ai>
Kody Review CompleteGreat news! 🎉 Keep up the excellent work! 🚀 Kody Guide: Usage and ConfigurationInteracting with Kody
Current Kody ConfigurationReview OptionsThe following review options are enabled or disabled:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Title: Fix piped interactive installs
This pull request fixes a bug where running
dotin interactive mode with piped input (e.g.,echo "..." | dot) would fail because the standard input was not a terminal. The changes ensure interactive prompts are still displayed and read from the real terminal even when stdin is redirected or piped. Additionally, non-interactive install commands are now executed with their standard input explicitly ignored, preventing them from accidentally consuming the parent’s piped data.Major changes include:
openTerminalInpututility that opens/dev/ttyto provide a terminal-backed input stream whenprocess.stdinis not a TTY.promptschecklist.installComponentanduninstallComponentto useBun.spawnwithstdin: "ignore"instead of appending< /dev/nullto shell commands, avoiding unintended side effects with piped input.This ensures
dotbehaves correctly in complex shell pipelines, whether running an interactive setup or executing automated installs.