Skip to content

Accessibility improvements - #279

Merged
panglesd merged 10 commits into
mainfrom
accessibility-review
Aug 30, 2026
Merged

Accessibility improvements#279
panglesd merged 10 commits into
mainfrom
accessibility-review

Conversation

@panglesd

Copy link
Copy Markdown
Owner

First pass on HAN accessibility report - Slipshow.pdf

Fixes:

  • Part of issue nr 5: Hover cursor on step number
  • Part of issue nr 12: Hover cursor on toc entries
  • Issue nr 9: Play from beginning if play is pressed when time is at the end
  • Issue nr 15: Too specific precision and bug mentioned

@coderabbitai

coderabbitai Bot commented Aug 29, 2026

Copy link
Copy Markdown

Review Change Stack

Note

Reviews paused

It looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the reviews.auto_review.auto_pause_after_reviewed_commits setting.

Use the following commands to manage reviews:

  • @coderabbitai resume to resume automatic reviews.
  • @coderabbitai review to trigger a single review.

Use the checkboxes below for quick actions:

  • ▶️ Resume reviews
  • 🔍 Trigger review

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 3c9e2aab-1abe-4b0e-8946-ad50796e46da

📥 Commits

Reviewing files that changed from the base of the PR and between 181990c and 134d3e0.

📒 Files selected for processing (1)
  • CHANGELOG.md

Included review availability: Your plan provides up to 4 included reviews per hour; 1 remains after this review.


📝 Walkthrough

Walkthrough

Playback timing and pause handling now use Drawing_state.play. The drawing controller and Draw.replay provide continuation and completion callbacks. Pause selection excludes the current pause and detects pauses at the new time. Replay completion uses the next representable float after the recording duration. The float widget filters untrusted events and converts displayed values to integers. Hover styles were added for the playback counter and table-of-content steps.

Suggested reviewers: itay-raveh

Merge Risk: 🔵 Low · up to 134d3

The accessibility and playback updates are mergeable with owner awareness, but malformed programmatic input could still fail before the trusted-event check is applied, creating a bounded runtime robustness risk that should be fixed or explicitly accepted.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title is concise and related to the accessibility-focused changes. It does not mention the playback and precision fixes, but it accurately describes the main objective.
Description check ✅ Passed The description identifies the accessibility report and lists changes that match the pull request, including hover behavior, replay from the beginning, and precision fixes.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage

Explanation

No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. (1 skipped: 1 unsupported.)


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 3


ℹ️ Review info
⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 100b6d55-ab81-4fe0-9784-ea9ad99bd1ea

📥 Commits

Reviewing files that changed from the base of the PR and between 62b4666 and 8412037.

📒 Files selected for processing (6)
  • src/engine/runtime/drawing/drawing_controller/ui.ml
  • src/engine/runtime/drawing/drawing_controller/ui_widgets.ml
  • src/engine/runtime/drawing/drawing_state/drawing_state.ml
  • src/engine/runtime/step/actions_.ml
  • src/engine/runtime/step/step.css
  • src/engine/runtime/table_of_content/table_of_content.css

Included review availability: Your plan provides up to 4 included reviews per hour; 3 remain after this review.

Comment thread src/engine/runtime/drawing/drawing_controller/ui_widgets.ml
Comment thread src/engine/runtime/drawing/drawing_state/drawing_state.ml
Comment thread src/engine/runtime/step/actions_.ml
- Pauses are activated when we pass them from before
- We go one float after max_time to draw the last point

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1


ℹ️ Review info
⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro Plus

Run ID: ca044e85-0396-45ba-a489-af2f8e129d64

📥 Commits

Reviewing files that changed from the base of the PR and between 8412037 and 17c1877.

📒 Files selected for processing (1)
  • src/engine/runtime/drawing/drawing_state/drawing_state.ml

Included review availability: Your plan provides up to 4 included reviews per hour; 3 remain after this review.

Comment thread src/engine/runtime/drawing/drawing_state/drawing_state.ml Outdated
@panglesd
panglesd merged commit 5bb41c6 into main Aug 30, 2026
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant