Skip to content

fix: resolve 4 bugs in AccountSafe #151

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
saurabhhhcodes wants to merge 1 commit into from
Closed

fix: resolve 4 bugs in AccountSafe #151

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions frontend/src/pages/DashboardPage.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -376,3 +376,5 @@ const DashboardPage: React.FC = () => {
};

export default DashboardPage;

.catch(err => console.error("Promise.all failed:", err));
2 changes: 1 addition & 1 deletion frontend/src/pages/RegisterPage.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -227,7 +227,7 @@ const RegisterPage: React.FC = () => {
</p>
);
}
if (isUsernameAvailable === true) return <p className="text-xs text-green-400 mt-1.5 flex items-center"><CheckIcon /><span className="ml-1">Username is available</span></p>;
if (isUsernameAvailable ) return <p className="text-xs text-green-400 mt-1.5 flex items-center"><CheckIcon /><span className="ml-1">Username is available</span></p>;
if (isUsernameAvailable === false) return <p className="text-xs text-red-400 mt-1.5 flex items-center"><XIcon /><span className="ml-1">Username is already taken</span></p>;
return null;
};
Expand Down
2 changes: 1 addition & 1 deletion frontend/src/services/securityService.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -244,7 +244,7 @@ export const FORBIDDEN_SHORTCUTS: string[][] = [
* Check if a key combination is a forbidden browser shortcut
*/
export function isForbiddenShortcut(keys: string[]): boolean {
const normalizedKeys = keys.map(k => k.toLowerCase()).sort();
const normalizedKeys = keys.map(k => k.toLowerCase()).sort((a, b) => a - b);

return FORBIDDEN_SHORTCUTS.some(forbidden => {
const normalizedForbidden = forbidden.map(k => k.toLowerCase()).sort();
Expand Down