feat(ide): replace hir-ty TypeSystem with resident slang elaboration - #345
Closed
hongjr03 wants to merge 1 commit into
Closed
feat(ide): replace hir-ty TypeSystem with resident slang elaboration#345hongjr03 wants to merge 1 commit into
hongjr03 wants to merge 1 commit into
Conversation
Slang's Compilation is not incremental, so types, class members, and `::` navigation come from a resident worker rather than salsa inference. Hover, member completion, and extract-variable ask that worker; HIR display stays as pretty-printing of lowered syntax and moves into ide. The hir-ty crate is removed. ModuleIndex and the preprocessor are unchanged.
|
Docs preview: https://vide.pascal-lab.net/preview/pr-345/ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Split out of #344. This PR is only the type/elaboration slice: types, class members, and
::navigation come from a resident slangCompilationworker instead ofhir-ty::TypeSystem.What this is
lookup_symbol,lookup_scoped,list_members,list_scope_members,lookup_type,list_instancesElaborationServiceworker thread (not salsa)Class::membergoto ask that workerhir-tyintoide::render::hir_displayhir-tycrate deletedWhat this is not
ModuleIndexandsemantic_indexstay#344(perf) remains the spec branch until the other slices land.Tests
cargo test -p slang-syscargo test -p ide --lib