-
-
Notifications
You must be signed in to change notification settings - Fork 2.8k
feat(editor): expose exportFloorplanPdf and add structure+utility export scope #636
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
SomSamantray
wants to merge
6
commits into
pascalorg:main
Choose a base branch
from
SomSamantray:feat/floorplan-export-routing-scope
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
4b0d234
feat(editor): add structure+utility 'routing' floorplan export scope
SomSamantray 3a05e57
feat(editor): export exportFloorplanPdf from the package entry
SomSamantray 617b81e
fix(review): add package-entry re-export smoke test and drop redundan…
SomSamantray 39256ca
docs(review): record residual review findings
SomSamantray 9e7435e
refactor(editor): drop routing floorplan export scope
SomSamantray f730e4f
docs(review): drop residual-findings file, not a supported doc location
SomSamantray File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,17 @@ | ||
| import { describe, expect, test } from 'bun:test' | ||
| import { exportFloorplanPdf, type FloorplanExportScope } from '@pascal-app/editor' | ||
|
|
||
| // Runtime smoke assertion for the package-entry re-export (plan U2 / issue | ||
| // #619): this test imports the whole @pascal-app/editor barrel, so if the | ||
| // entry stops re-exporting `exportFloorplanPdf` or the `FloorplanExportScope` | ||
| // type, the import fails at test-run time (and `check-types`) instead of the | ||
| // regression passing silently. Runtime coverage of the export pipeline | ||
| // itself lives in @pascal-app/editor's floorplan tests; here we only pin the | ||
| // public surface. | ||
| describe('package entry floorplan export surface', () => { | ||
| test('exportFloorplanPdf accepts every scope member', () => { | ||
| const scopes: FloorplanExportScope[] = ['full', 'structure'] | ||
| expect(scopes).toEqual(['full', 'structure']) | ||
| expect(typeof exportFloorplanPdf).toBe('function') | ||
| }) | ||
| }) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Routing export scope never added
Medium Severity
FloorplanExportScopeandisFloorplanNodeInExportScopestill only distinguishfullandstructure. Hosts cannot request the advertisedroutingsheet that keeps structure and utility nodes (ducts, pipes, HVAC) while dropping furniture.Additional Locations (2)
apps/editor/lib/floorplan-export-surface.test.ts#L12-L14packages/editor/src/lib/floorplan/floorplan-export.test.ts#L321-L355Reviewed by Cursor Bugbot for commit f730e4f. Configure here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is expected, not a regression: the
'routing'scope was intentionally dropped from this PR per @Aymericr's review (comment above) — it had no UI trigger anywhere in the tree (#632) and its name would have collided withPrintContentScopefrom #701. It's deferred to a follow-up PR with a UI trigger and a non-colliding name ('services'/'mep'suggested). See the updated PR description for the full context.