Level pill: no ground-floor delete; hide compass in studio - #722
Closed
wass08 wants to merge 1 commit into
Closed
Conversation
The floating level selector's kebab offered Delete for the ordinal-0 ground floor — the vertical model's zero anchor — while the site panel and command palette already guard it; disable it with the same rule and explanatory title. The floorplan compass portaled into the viewer area outlived the studio stage overlays (gallery, materials, item builder); gate it on the edit workspace like the rest of the editor chrome. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01SrRkPvd6AogVAbt3PNeLAw
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #721 — retarget to
mainafter it merges.What
level.level !== 0) and the same explanatory title as the site panel.display:none), which also let it paint above the studio stage overlays — it showed in the gallery/materials/item-builder tabs. Now gated on the edit workspace, same pattern asHelperManager.Verification
Playwright probe against the running community app: Ground Floor's Delete item renders disabled with the tooltip; compass hidden after switching to Studio; compass returns in Edit.
Note for reviewers
There is no store-layer guard for ground-floor deletion —
deleteNode/deleteLevelWithFallbackSelection/ MCPdelete-nodeall delete it unconditionally; every guard is UI-level (site panel, command palette, now the pill). A core-level guard may be worth a follow-up.🤖 Generated with Claude Code
https://claude.ai/code/session_01SrRkPvd6AogVAbt3PNeLAw
Note
Low Risk
UI-only guards in two components; no changes to delete or scene APIs, though ground-floor deletion remains possible outside these UI paths.
Overview
Aligns two floorplan UI edges with existing rules elsewhere in the editor.
The floating level selector kebab menu now disables Delete level when the level ordinal is 0 (ground floor), with the same disabled styling and tooltip as the site panel — previously only the site panel and command palette blocked deleting the vertical model’s zero anchor.
The floorplan compass is now shown only in the edit workspace (
!isStudioWorkspace), matchingHelperManager, so it no longer appears over studio tabs (gallery, materials, item builder) after being portaled into the viewer.Reviewed by Cursor Bugbot for commit 8b23ee8. Bugbot is set up for automated code reviews on this repo. Configure here.