feat(sqs): stop read mode after max_records - #125
Merged
Merged
Conversation
Match Kafka: cap forwarded messages per worker and size the next ReceiveMessage to remaining so leftover receipts are not held.
Divyanshu Tiwari (divyanshu-tiwari)
requested a review
from a team
as a code owner
September 15, 2026 14:12
max_records only stops forwarding, matching Kafka. Do not shrink the poll.
Keep delivery mode from main and max_records stop from this branch.
snehalahire-pattern
approved these changes
Sep 15, 2026
Divyanshu Tiwari (divyanshu-tiwari)
deleted the
feat/sqs-max-records
branch
September 15, 2026 14:37
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
max_recordson the SQS reader (0/omitted = unlimited). Cap is per worker.ReceiveMessageis sized tomin(max_messages, remaining)so leftover receipts are not held until visibility timeout.max_messagesis unchanged (per-poll batch size, AWS cap 10).Test plan
max_recordsset stops after that many forwarded messages and leaves the rest in the queuemax_records,exit_on_empty, norend_afterstill polls until the job timeoutmax_messages: 1Keepa-style jobs are unaffected