feat(file): read matched files concurrently - #128
Merged
Merged
Conversation
Keep a file source on one pipeline worker so a glob is not parsed twice, and use task_concurrency to bound parallel fetches of those files.
prasadlohakpure
previously approved these changes
Sep 23, 2026
Aditya Muley (aditya2muley)
previously approved these changes
Sep 23, 2026
Address PR #128 review: shorten the read-mode task_concurrency description and remove file_test.go per the repo's convention of keeping test pipelines rather than Go test files. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Mahesh Kamble (ma-gk)
dismissed stale reviews from Aditya Muley (aditya2muley) and prasadlohakpure
via
September 30, 2026 08:50
c9cb490
Divyanshu Tiwari (divyanshu-tiwari)
approved these changes
Sep 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
File source tasks stay on a single pipeline worker so a glob is parsed once and files are not duplicated.
task_concurrencynow bounds how many of those matched files are fetched in parallel. A read error cancels the remaining fetches, andfail_on_errorstill fails the run.Write tasks are unchanged:
task_concurrencystill means competing-consumer workers.Types of changes
Checklist
Test plan
go test ./internal/pkg/pipeline/task/file/— concurrent read of 10 temp files returns every recordtest/pipelines/file_concurrency_test.yaml(task_concurrency: 3over 100 nested files) and confirm 100 outputs under./output/test/pipelines/file_read_failure.yamland confirm the run fails when the glob matches a directorytask_concurrencygreater than 1 still uses competing workers