test: reuse verified identity in transition race probes - #80
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
The transition-state race test now resolves the effective account identity once per test process and passes that verified value to its child probes. The probes still run as separate Bun processes, resolve the same canonical coordinator database path, and assert the exact busy/unsafe outcomes.
Why
The development cross-platform Windows job failed twice in
a locked coordinator returns the exact typed busy outcome: a repeated PowerShell SID lookup timed out under full-suite load (CodexUserIdentityRefusal: ... exit unknown). The dedicated Windows account coordination and identity tests retain live SID-resolution coverage. This change keeps the transition test focused on process concurrency and locking.Verification
bun test tests/codex-transition-state-race.test.ts— 4 passedbun run typecheck— passedgit diff --check— passedbun run test:parallel— all 630 files passed locally (3.4 min).This is a test-only change. No runtime identity, credential, or logging behavior changes.