FIX: Stop the admin wizard editor crashing on multiple mapper inputs - #320
Merged
Merged
Conversation
angusmcleod
force-pushed
the
fix/admin-wizard-editor
branch
2 times, most recently
from
September 8, 2026 08:50
7a32f48 to
114094e
Compare
WizardMapper renders the connector between its inputs without passing
connectors, as that connector is a label rather than a combo box. The
GJS migration replaced the null safe gt("connectors.length", 1) macro in
WizardMapperConnector with this.connectors.length > 1, so rendering a
mapper with more than one input threw:
TypeError: Cannot read properties of undefined (reading 'length')
That is an unrecoverable Ember render error, so it took the whole admin
wizard editor down with it: only the first condition on a step rendered,
the add buttons for conditions, required data and permitted params did
nothing, the form went blank after saving, and switching steps no longer
updated the fields shown.
Meta: https://meta.discourse.org/t/custom-wizard-plugin/73345/991
angusmcleod
force-pushed
the
fix/admin-wizard-editor
branch
from
September 8, 2026 08:50
114094e to
9ff0bf5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WizardMapperrenders the connector between its inputs without passingconnectors. The GJS migration replaced the null safegt("connectors.length", 1)macro withthis.connectors.length > 1, so any mapper with more than one input threw a render error, which took the whole admin wizard editor down with it.Reported in meta #991.