Align dashboard EU onboarding e2e with the re-enabled Monerium flow - #1377
Merged
Merged
Conversation
1b4c4aa switched EU onboarding back on, but the dashboard specs still asserted the July disabled state, so the nightly e2e job has failed since. Restore the OAuth round-trip coverage the disable commit told us to bring back, ending on the new wallet-link step, and let the quote explorer route an approved EUR BUY into the transfer form. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
✅ Deploy Preview for vortexfi ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for vortex-sandbox ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for vrtx-dashboard ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The test-only updates consistently reflect the restored EU onboarding and transfer behavior.
Pull request overview
Updates dashboard end-to-end tests to match the re-enabled Monerium EU onboarding and EUR onramp flow.
Changes:
- Restores Monerium OAuth, callback, approval, wallet-linking, and reauthentication coverage.
- Verifies approved EUR purchases navigate to the EU onramp transfer form.
File summaries
| File | Description |
|---|---|
| apps/dashboard/e2e/quote-explorer.spec.ts | Updates EUR quote and transfer navigation expectations. |
| apps/dashboard/e2e/onboarding-monerium-eu.spec.ts | Restores active Monerium onboarding flow coverage. |
Review details
- Files reviewed: 2/2 changed files
- Comments generated: 0
- Review effort level: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The nightly e2e job (run 35302228341) has 5 dashboard Playwright failures, all with the same cause: 1b4c4aa (PR #1359, merged via #1372) re-enabled EU onboarding and EUR pay-ins, but the specs still asserted the July "EU is disabled" state.
isCorridorOnboardingDisablednow returnsfalsefor every corridor andEUis back inONRAMP_CORRIDORS, so "KYC is temporarily unavailable", "KYC is currently disabled in Europe." and "Buying crypto with EURC isn't available in transfers yet." no longer render anywhere.Test-only change, no app code touched.
/v1/monerium/status; the approved EUR BUY asserts "Continue to transfer" lands on/transfer?corridorId=EU&mode=onrampinstead of the removed notice.Test plan
bun run test:e2e e2e/onboarding-monerium-eu.spec.ts e2e/quote-explorer.spec.tsinapps/dashboard: 9/9 pass locallyCo-Authored-By: Claude Opus 5 noreply@anthropic.com