Repository navigation
Conversation
This was referenced Sep 11, 2026
Member
|
thank you! can you rebase this? |
fouteox
force-pushed
the
feat/observe-final-exit-code
branch
from
October 11, 2026 10:56
292f16f to
33c11b7
Compare
Author
|
Done, rebased on 5.x. The only conflict was the test count in the suite snapshot. Heads up while running it locally: paratest v7.26.1 added a fifth |
fouteox
force-pushed
the
feat/observe-final-exit-code
branch
from
October 13, 2026 06:07
33c11b7 to
1e01dd6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What:
Description:
Output plugins can change the exit code after another plugin has already observed it, so a reporter can announce success while a later coverage check fails the command. Add the
ObservesExitCodeplugin contract and notify its observers after everyAddsOutputplugin has run. Observers receive the same resulting code and do not return a replacement value; the shared action covers sequential and parallel execution.Seven tests cover output-plugin ordering, multiple observers, unchanged codes including custom codes, runs without observers, and output-plugin exceptions. The suite-output snapshots and parallel summary are updated for those additional tests.
Validation on macOS / PHP 8.5.10:
The full upstream PHP/OS matrix has not been run.
Prepared with AI assistance.