Repository navigation
Conversation
1 of 2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What:
Description:
On
--tia --coverageruns,Graph::replaceEdges()is called withkeepExisting: trueand skips every test file that already has edges. A test that starts using a new file never gets that edge, so a later change to the file replays the test as passed.This takes the change suggested in the issue: with
keepExisting, the new edges are added to the recorded set instead of being dropped. The coverage report still cannot narrow a recorded set, and a plain--tiarun still replaces it.The new test in
tests/Features/Tia/CoveragePiggyback.phpmakesGreetercallCalculatorand expectsapp/Calculator.phpin the edges ofGreeterTestafter a coverage run. It fails on5.xin the sequential and parallel datasets. It skips without a coverage driver, like the xml coverage test above it.Related:
Fixes #1953