Repository navigation
fix: support brianium/paratest 7.26.1 worker tmp dir - #1959
Conversation
paratest 7.26.1 added a required $tmpDir argument to WrapperWorker and keeps worker files in a private per-run directory. Create that 0700 directory per run, pass it to each worker and remove it on completion. Require paratest ^7.26.1.
|
@nunomaduro @MrPunyapal could one of you approve the CI workflows for this PR? Since |
|
The
|
|
@MrPunyapal heads-up: the Could you re-run the failed and cancelled jobs on this PR once the runner is fixed? |
|
thank you! can you check the failing tests? |
|
@nunomaduro no test fails: the only failing job is
|
What:
Description:
brianium/paratestv7.26.1 (paratestphp/paratest#1148) added a requiredstring $tmpDirargument toWrapperWorker::__construct(), so every--parallelrun fails withArgumentCountError.This ports the same change to Pest's
WrapperRunner:0700directory per run ({tmpDir}/pest_<random hex>) and pass it to eachWrapperWorker.mkdiris intentionally not followed by anis_dir()fallback: a pre-existing path may have been planted by another user, and the main process deserializes/includes worker files from it.complete()after the worker files are cleared.brianium/paratest: ^7.26.1.Only 5.x is affected: paratest 7.26.1 requires
phpunit/phpunit ^13.4.1, which 3.x and 4.x cannot resolve.Note:
Tests\Features\Tia > it does not run user hooks when replaying cached skipped and incomplete resultsfails intermittently undercomposer test:parallelon a clean5.xwith paratest 7.26.0 as well; it is unrelated to this change.Related:
Fixes #1958