Repository navigation
test(tia): cover monorepo baseline and path regressions - #1960
Draft
einar-hansen wants to merge 1 commit into
Draft
einar-hansen wants to merge 1 commit into
einar-hansen wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What:
Description:
Add regression coverage for TIA baseline detection and file selection in monorepos. These cases preserve coverage from #1809 alongside the implementation in #1914.
Depends on #1914. This draft targets
5.xand contains tests and output snapshots only. It does not include the implementation from #1914. Keep the draft blocked until that prerequisite merges.The 26 new cases cover:
gitdirandcommondirpointers, and malformed nested Git metadata without falling back to the parent remote.core.quotePath=true, staged and committed moves outside the project, cosmetic changes, and untracked files.The Unicode cases use an actual
Æcharacter. PHP leaves the single-quoted\u{26a1}strings in #1914 literal, so those existing fixtures do not exercise non-ASCII filenames.Validation:
Validated in a temporary checkout combining upstream
83baa5deand #1914 at85aac6a8, with this PR's tests applied.composer test: passed, including Rector, Pint, PHPStan, 100% type coverage, unit tests, parallel tests, and integration tests.The output snapshots include #1914's tests and the 26 cases added here. The parallel summary changes from 1,581 passed / 3,431 assertions to 1,622 passed / 3,483 assertions. Snapshot regeneration changed only
tests/.snapshots/success.txtand the expected summary intests/Visual/Parallel.php.The validation checkout uses PHP 8.5.10 and ParaTest 7.26.0. ParaTest 7.26.1 introduces an unrelated upstream
WrapperWorkerconstructor incompatibility. The dependency constraint and application code are unchanged in this PR.Related: