docs: say which tmux lemonaid and follow mode need - #44
Open
timblass wants to merge 1 commit into
Open
Conversation
The follow hook uses the #{!:...} format operator, which tmux added in
3.6. On 3.5a it expands to nothing, so the hook's condition is never
true and the sidebar stays in the window it was in. Nothing in the
code changes; the README, docs/tmux.md, and CHANGES.md now state the
minimum (3.0 for lemonaid, 3.6 for follow mode) and there is a
troubleshooting entry for the symptom.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
馃崑:
Docs only. Nothing in the code changes.
The repo did not say which tmux it needs. I hit this on tmux 3.5a: with follow mode on, the sidebar stayed in the window it was in when I switched windows.
The cause is in the follow hook.
hook_condition()and_came_from()insrc/lemonaid/tmux/follow.pyuse the#{!:...}format operator, which tmux added in 3.6 (from tmux's CHANGES, "CHANGES FROM 3.5a TO 3.6": "add ! and !! for not and not-not"). On an older tmux that term expands to an empty string, so the hook's condition is never true and nothing joins the pane into the new window. Everything else the tmux integration uses is older: pane options and array hooks are from 3.0,run-shell -Cand format arithmetic from 3.2.This PR:
docs/tmux.mdunder Setup, stating 3.0 as the floor for lemonaid and 3.6 for follow mode, with the reason