Repository navigation
Fix malformed Desktop packaging workflow YAML - #113
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 635f47e44a
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| retention-days: 14 | ||
| | sort -V | tail -n 1 || true)" | ||
| if [[ -z "$version" ]]; then version=v0.1.0; else version="$(awk -F. '{printf "v%d.%d.%d", substr($1,2),$2,$3+1}' <<< "$version")"; fi | ||
| version="$(gh release list --repo "$GITHUB_REPOSITORY" --limit 1000 --json tagName --jq '.[].tagName' | grep -E '^v[0-9]+\\.[0-9]+\\.[0-9]+$' | sort -V | tail -n 1 || true)" |
There was a problem hiding this comment.
When the repository contains a release such as v0.1.0, the single-quoted pattern passes two backslashes before each dot to grep, so it does not match ordinary version tags. Consequently, every packaging run falls back to v0.1.0; after the first release, publish-desktop-release.yml lines 59–61 rejects that already-existing version, preventing subsequent releases. Use a single backslash before each dot in this shell regex.
Useful? React with 👍 / 👎.
Restore the manual Desktop packaging workflow after the version calculation edit corrupted its YAML: an unterminated shell command and duplicated job steps made GitHub Actions unable to parse the file.
This change removes the duplicated block and retains manual dispatch, Windows/Linux matrix builds, version manifest creation, and artifact uploads.
The workflow has not yet been run after this fix.