fix: live preview control box stale attributes and execPhoenixFn hangs#3020
Open
devvaannsh wants to merge 2 commits into
Open
fix: live preview control box stale attributes and execPhoenixFn hangs#3020devvaannsh wants to merge 2 commits into
devvaannsh wants to merge 2 commits into
Conversation
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds two small live preview fixes.
Stale control box attributes - So earlier when we edit elements attributes (like id or class) directly in the source code, the control box in the live preview kept showing the old values. Now whenever the selected element's markup changes, we refresh the control box content in place so it always stays in sync with the code.
execPhoenixFn promises hanging forever - sometimes when the editor got disconnected while a execPhoenixFn call was in flight, the promise never resolved and whoever was awaiting it (like the styles bar reset) just hung forever. Now, we have a 30s timeout so it rejects instead of hanging.
Tested things properly. Safe to merge!