fix: Phoenix sidebar resize broken and redundant space reservation in title bar in desktop apps #3021
Open
devvaannsh wants to merge 3 commits into
Open
fix: Phoenix sidebar resize broken and redundant space reservation in title bar in desktop apps #3021devvaannsh wants to merge 3 commits into
devvaannsh wants to merge 3 commits into
Conversation
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR holds the following fixes:
Sidebar collapsing on a quick click after resize - after resizing the sidebar, clicking on the editor instantly closed the sidebar. Found that there's a shield that stays on screen for 300ms (the idea was for that to catch double clicks on the sidebar resizer). Problem is the shield covers the whole window, so if we clicked anywhere (like the editor) within 300ms, it got treated as a double click and collapsed the sidebar.
Fix: removed the shield after a real drag, and a click only counts as a double click if it actually lands on the resizer (or near that)...
Empty space reserved for the title bar in desktop apps - In the desktop app the OS window title bar already shows the file name, so our in-app title is hidden. But we were still reserving layout space for it, leaving a useless gap above the editor. Skipped all that title layout work for the native app.