[danielfikko]

The version 2 allows the client to enable or disable window decorations at runtime. See for more information:

https://gitlab.freedesktop.org/wayland/wayland-protocols/-/work_items/9
https://gitlab.freedesktop.org/wayland/wayland-protocols/-/commit/fedde2456ed1572ad4d46fff119220cb845e79d6

In winex11, there is an option to disable or enable window decorations:

One of the reasons winewayland does not support server-side decorations is the lack of compositors implementing version 2 of the xdg-decoration protocol, which would facilitate the implementation of this Wine option.

Depends on this commit: https://gitlab.freedesktop.org/wlroots/wlroots/-/commit/bd99e8c2bd077251e8fe1f21ed5ed2ddb92c9cf0. So this PR will presumably have to wait for wlroots 0.21.

[phkaeser]

Thanks for the PR! Yes, this will need some changes for wlmaker to use wlroots at head (until the upstream change is in a tagged release).

Additionally, it'll be good to add a #ifdef conditional around this change, based on the WLR_VERSION (to not use the extra parameter for versions up to 0.20).

(managing expectations: I won't be able to make time for this before the weekend, though)

[danielfikko]

Hm, maybe I can't do it either. I don't know how to program in C, I just used the sway implementation as a reference, since in this case, the implementation is pretty straightforward in most wlroots-based compositors.

[phkaeser]

Updated the build system to accept wlroots 0.21 with #566 , and modified the PR to compile the additional argument conditionally, depending on the used wlroots version.

Thanks for the PR!