[tayloraj10]

Migrate reviews to resource_edits (replaces broken partial rename on main)

Problem

The review dashboard (/reviews, /reviews/:id, and the dashboard summary) was built against resource_revisions, a throwaway staging table. The real table this app should build forward on is resource_edits (added in #24), which already ships the approve_edit/reject_edit/rollback_to_edit RPCs, a new-resource submission path (mapped_resource IS NULL), and ready-made review-queue views — none of which resource_revisions has.

Separately, main picked up a partial, incomplete rename to resource_edits as a side effect of an unrelated PR (#41). That version only renamed the table string and a couple of field names, but the underlying logic is still broken:

• Approve/Reject is currently a silent no-op. The action writes to a column called status instead of review_status (the actual review-state column — status on this table is just a mirrored copy of the resource's operational status). It also never calls the RPCs, so even a "successful" click never copies the proposed changes into resources — nothing goes live on the map, and no error is shown to the reviewer.
• No handling for brand-new site submissions (mapped_resource IS NULL) — these don't show up in the queue at all.
• Reviewer attribution never worked, because nothing ever set reviewed_by/reviewed_at — that's why the dashboard's "Top approvers" card has been disabled with a placeholder tooltip.
• resource_edits was missing an UPDATE policy for authenticated reviewers, so edits made on the detail page before approval (the "Save changes" button) were silently dropped by RLS.

Solution

• Added app/api/resource-edits/methods.ts and app/types/ResourceEdit.ts (clearly named after the table they wrap), replacing app/api/resource-revisions/methods.ts and app/types/ResourceRevision.ts (deleted).
• /reviews now merges the edit queue (resource_edits_queue) and new-resource queue (new_resources_queue) into one table, with a "Kind" (New/Edit) column.
• /reviews/:id approve/reject now call the real approve_edit/reject_edit RPCs (capturing the reviewer's email from context.get(userContext)), so approving an edit actually applies it to resources and goes live on the map. Handles brand-new submissions without the "resource not found" warning.
• dashboard.tsx migrated too; "Top approvers" is now live since the RPCs set reviewed_by.
• Added supabase/migrations/20260728000000_resource_edits_update_policy.sql, the missing UPDATE policy scoped to PENDING rows for authenticated reviewers (approve/reject still must go through the RPCs — the policy's with check blocks flipping review_status directly).

Manual step before/after merge: the RLS migration above hasn't been applied to the live Supabase DB yet — this repo only has the anon key, so it needs to be run via the Supabase SQL editor or CLI with an owner/service-role credential. Until then, "Save changes" on the detail page will still silently no-op.

Reference

Closes #34. Builds on the table/RPCs added in #24.

Screenshots

N/A — no visual/UI changes, this is a data-source swap behind the existing review UI.

Checklist

• Changes have been tested locally
• Changes have been self-reviewed

[RNR1]

LGTM - these comments should be addressed as follow ups, except removing the what's next doc

[RNR1]

Ideally, we run aggregation queries on the database level instead of manipulating the data in code

[tayloraj10]

will fix in a future PR, have an issue to track this

[RNR1]

same here - ideally the data is already prepped for usage by the time it gets here

[tayloraj10]

will fix in a future PR, have an issue to track this