Skip to content

Show which fields have received changes - #55

Open
nathanktruong wants to merge 1 commit into
mainfrom
52/point-changed-fields
Open

nathanktruong wants to merge 1 commit into
mainfrom
52/point-changed-fields

Conversation

@nathanktruong

@nathanktruong nathanktruong commented Oct 20, 2026 •

Copy link
Copy Markdown

Show which fields have received changes

Problem

As we expect to get an influx of new resources, easing the effort for the reviewers is a priority!

As the ticket mentioned, it's unclear on a skim which resource fields are actually being changed, since proposed edits could be the same or look very similar to whats current. Accidentally approving inaccurate information might lead PHLASK users astray if its taken seriously.

Solution

Adds a table column — that points to the row when current + proposed are fully different values. This means it'll also flag trailing whitespace.

Reference

Addresses #52

Screenshots

Screenshot of PHLASK's resource review form

Checklist

  • Changes have been tested locally
  • Changes have been self-reviewed

@nathanktruong nathanktruong changed the title #52 show which fields have received changes Show which fields have received changes Oct 20, 2026
@nathanktruong nathanktruong self-assigned this Oct 20, 2026
@nathanktruong

Copy link
Copy Markdown
Author

to whomever reviews this - there were some additional pieces from self-review that I decided to not include in these changes:

1. some fields don't have their own changed field, such as Hours and Images.

With the current logic, they would be flagged as changed since they are technically different values but not actually. Looking at the other review forms, those fields aren't too important for review at the moment so for the interest of time, I omitted flagging changes there.

2. reducing repetitiveness

I looked into a partial refactor of the table to auto-populate the rows based on a list of definite fields (so that future alterations are smaller), but there's more digging into the structure of how this all is wired together.

@nathanktruong
nathanktruong marked this pull request as ready for review October 20, 2026 22:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant