feat(panel): add UserRbacRow typed view-model so adapters render RBAC role and permission rows from a single normalized shape. - #9
Conversation
…AC role and permission rows from a single normalized shape.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Plus Run ID: 📒 Files selected for processing (3)
Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review. 📜 Recent review details⏰ Context from checks skipped due to timeout. (4)
🧰 Additional context used🧠 Learnings (1)📚 Learning: 2026-08-14T23:49:48.417ZApplied to files:
🪛 PHPMD (2.15.0)tests/Panel/User/UserRbacRowTest.php[error] 40-46: Avoid using static access to class '\PHPForge\Debug\Panel\User\UserRbacRow' in method 'testFromArrayCastsNumericStringTimestampsToInt'. (undefined) (StaticAccess) [error] 54-63: Avoid using static access to class '\PHPForge\Debug\Panel\User\UserRbacRow' in method 'testFromArrayCoercesNonStringTextualFieldsToEmptyStrings'. (undefined) (StaticAccess) [error] 73-73: Avoid using static access to class '\PHPForge\Debug\Panel\User\UserRbacRow' in method 'testFromArrayDefaultsMissingKeysToEmptyStringsAndNullTimestamps'. (undefined) (StaticAccess) [error] 85-94: Avoid using static access to class '\PHPForge\Debug\Panel\User\UserRbacRow' in method 'testFromArrayHydratesAllFieldsFromCompleteRow'. (undefined) (StaticAccess) [error] 106-111: Avoid using static access to class '\PHPForge\Debug\Panel\User\UserRbacRow' in method 'testFromArrayRejectsNonNumericTimestamps'. (undefined) (StaticAccess) [error] 119-124: Avoid using static access to class '\PHPForge\Debug\Panel\User\UserRbacRow' in method 'testFromArrayTruncatesFloatTimestampsToInt'. (undefined) (StaticAccess) 🔇 Additional comments (3)
📝 WalkthroughSummary by CodeRabbit
WalkthroughAdded the readonly ChangesRBAC row value object
RBAC row validation
Estimated code review effort: 2 (Simple) | ~15 minutes Merge Risk: ⚪ Minimal · up to This PR adds a localized typed view-model and its tests without any identified merge-blocking risk; it is merge-ready after normal checks and review. Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #9 +/- ##
============================================
+ Coverage 90.56% 90.59% +0.02%
- Complexity 1334 1344 +10
============================================
Files 117 118 +1
Lines 5248 5264 +16
============================================
+ Hits 4753 4769 +16
Misses 495 495 ☔ View full report in Codecov by Harness. |
Pull Request