Modernize HTML markup in phpinfo output#22370
Open
jordikroon wants to merge 1 commit into
Open
Conversation
Girgias
reviewed
Jun 20, 2026
Comment on lines
-788
to
+789
| php_info_print(PHP_EGG_LOGO_DATA_URI "\" alt=\"PHP logo\" /></a>"); | ||
| php_info_print(PHP_EGG_LOGO_DATA_URI "\" alt=\"PHP logo\"></a>"); |
Member
There was a problem hiding this comment.
I'm not sure I agree with removing the the / to indicate an empty tag.
Member
Author
There was a problem hiding this comment.
I believe it's better to not use the self closing variant. As "Self-closing tags () do not exist in HTML.".
This is acceptable by XHTML standards only.
https://developer.mozilla.org/en-US/docs/Glossary/Void_element#self-closing_tags
Member
There was a problem hiding this comment.
sigh, I do kinda hate the HTML spec at times.
Girgias
approved these changes
Jun 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.