Clarify that --exclude replaces the default exclusion list - #541
Merged
Conversation
The --exclude option replaces the default exclusion list instead of extending it. This is intended, but easy to miss: a custom exclusion list silently brings vendor code into the analysis, which inflates metrics such as LOC (see #364). - document the behavior and the default list in the --help output; - display an orange warning when a custom exclusion list does not contain "vendor" while a vendor directory is present in the analyzed directories.
Halleck45
force-pushed
the
exclude_vendor_warning
branch
from
July 29, 2026 05:43
e812e2f to
ad9fd27
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The --exclude option replaces the default exclusion list instead of extending it. This is intended, but easy to miss: a custom exclusion list silently brings vendor code into the analysis, which inflates metrics such as LOC (see #364).