[BC] simplified et secured releasing workflow - #546
Merged
Conversation
Halleck45
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For over 10 years, this repo has committed built release artifacts (phar, binaries, .deb) directly to master on every release. This bloats the repository and, worse, forced a bypass of master's branch protection, an attack surface that could let compromised artifacts be pushed under the guise of a routine release.
GitHub Releases have existed since 2017 on this repo, giving users nearly a decade to adopt them. They're a safer distribution channel: they support proper checksums, and GitHub flags malicious overwrites of published releases. Keeping the old commit-to-master path added no benefit and only complicated the build process.
For these reasons, this PR drops pushing release artifacts to master entirely.
Change
Only the release tag is pushed now; the version-bump commit still exists but is reachable solely via the tag, no master push, no bypass needed. CURRENT_TAG switched from git describe --tags (ancestry-based) to a version-sorted git tag lookup, and the Debian changelog range from ... to .., since the tag commit is no longer guaranteed to be an ancestor of master.
Impact
Releases no longer touch master. Published artifacts are unchanged; only their distribution channel (GitHub Releases exclusively) and integrity guarantees improve.