Repository navigation
Internal: Update Node.js runtime to 24.x (SUB-15388) - #4111
Open
DanielAR22 wants to merge 5 commits into
Open
DanielAR22 wants to merge 5 commits into
DanielAR22 wants to merge 5 commits into
Conversation
|
@DanielAR22 is attempting to deploy a commit to the Pinterest - Subsites Team on Vercel. A member of the Team first needs to authorize it. |
DanielAR22
changed the title
✅ Deploy Preview for gestalt ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify project configuration. |
DanielAR22
changed the title
DanielAR22
marked this pull request as ready for review
October 28, 2026 22:35
Use "24" instead of pinning 24.22.1 so local dev, devcontainer, and Netlify stay aligned with CI, which uses check-latest on Node 24. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Title:
Internal: Upgrade Node.js runtime from 20 to 24Labels:
patch,dependenciesSummary
What changed?
Upgrades Gestalt's Node.js runtime from 20.x to 24.x across local development, CI, and the docs site build:
.nvmrc:20→24.22.1. This is also the version Netlify uses to build the docs site.package.jsonanddocs/package.json: add"engines": { "node": "24.x" }.ci.yml,alpha.yml,playwright.yml,release.yml):node-version: 20→node-version: 24, withcheck-latest: trueso CI picks up the latest 24.x patch release.actions/checkout@v4→@v5andactions/setup-node@v4→@v5..devcontainer/devcontainer.json: imagejavascript-node:20→javascript-node:24..yarnrcwithignore-engines true.stylelint-value-no-unknown-custom-properties@5.0.0declaresengines.node: "^16 || ^18 || ^20", and Yarn 1 refuses to install it on Node 24 (The engine "node" is incompatible with this module). Versions 6.x support Node 24 but requirestylelint >=16, a larger migration outside the scope of this ticket. With this setting,yarn install --frozen-lockfilecompletes on Node 24.22.1. It can be removed once stylelint is upgraded (follow-up ticket).Why?
The Gestalt docs site still built on Node.js 20.x, which doesn't match the current site configuration and triggers a Node.js version override warning on every build. Node 20 is also reaching end-of-life. Moving to Node 24 (Active LTS) puts local dev, CI, releases, and the docs deploy on the same supported runtime, and removes the warning.
Links
Checklist
ci,playwright) passes on Node 24yarn install --frozen-lockfilesucceeds locally on Node 24.22.1yarn buildsucceeds locally on Node 24.22.1