Format unknown packet and SDES types as numbers - #231
Closed
RaphaelFakhri wants to merge 1 commit into
Closed
RaphaelFakhri wants to merge 1 commit into
RaphaelFakhri wants to merge 1 commit into
Conversation
PacketType.String and SDESType.String converted unknown values with string(p), which yields the Unicode character for that code point instead of the number. Use the same 'invalid value' format as BlockTypeType.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
PacketType.StringandSDESType.Stringconverted unknown values withstring(p), which returns the Unicode character for that code point.PacketType(65)printedAandPacketType(0)printed a NUL byte.Unknown values now use the same
invalid value %dformat asBlockTypeType.String.Tests
TestPacketTypeStringandTestSDESTypeString. Both fail without the change and pass with it.go test -race ./...andgolangci-lint run ./...pass.Fixes #230