Remove stats dropped from the specification - #3602
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## next #3602 +/- ##
==========================================
- Coverage 90.44% 90.40% -0.04%
==========================================
Files 81 81
Lines 9221 9193 -28
==========================================
- Hits 8340 8311 -29
- Misses 881 882 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
JoTurk
left a comment
There was a problem hiding this comment.
@kcaffrey you made this PR recently to fix the SLI parser pion/rtcp#222 do you use SLIs? I think if yes, we shouldn't remove the stats, even if removed by w3c and libwebrtc
|
how is sliceLoss filled? I've never seen it useful for the way webrtc does video encoding |
2e94412 to
bc6cabb
Compare
|
No, I don’t use SLIs. I was making some other edits to rtcp when I saw that bug and decided to fix it in its own PR (with the spirit of leaving things better than I found it). |
Removes stats dropped by w3c/webrtc-stats#622 that were not populated by pion either: | Type | Removed | |---------------------|-----------------------------------------------| | inbound-rtp | sliCount, packetsRepaired, burstPacketsLost, | | | burstPacketsDiscarded, burstLossCount, | | | burstDiscardCount, burstLossRate, | | | burstDiscardRate, gapLossRate, | | | gapDiscardRate, averageRtcpInterval, | | | packetsFailedDecryption, packetsDuplicated | | outbound-rtp | sliCount, packetsDiscardedOnSend, | | | fecPacketsSent, bytesDiscardedOnSend, | | | averageRtcpInterval | | remote-inbound-rtp | sliCount, packetsRepaired, burstPacketsLost, | | | burstPacketsDiscarded, burstLossCount, | | | burstDiscardCount, burstLossRate, | | | burstDiscardRate, gapLossRate, | | | gapDiscardRate | | remote-outbound-rtp | sliCount, packetsDiscardedOnSend, | | | fecPacketsSent, bytesDiscardedOnSend | | codec | codecType | | csrc | the whole type |
bc6cabb to
7edbba6
Compare
Removes stats dropped by
w3c/webrtc-stats#622
that were not populated by pion either:
(2017->2022, we are getting closer)