Skip to content

Remove stats dropped from the specification - #3602

Merged
fippo merged 1 commit into
nextfrom
stats-remove-slicount
Oct 2, 2026
Merged

fippo merged 1 commit into
nextfrom
stats-remove-slicount

Conversation

@fippo

@fippo fippo commented Oct 2, 2026

Copy link
Copy Markdown
Contributor

Removes stats dropped by
w3c/webrtc-stats#622
that were not populated by pion either:

Type Removed
inbound-rtp sliCount, packetsRepaired, burstPacketsLost,
burstPacketsDiscarded, burstLossCount,
burstDiscardCount, burstLossRate,
burstDiscardRate, gapLossRate,
gapDiscardRate, averageRtcpInterval,
packetsFailedDecryption, packetsDuplicated
outbound-rtp sliCount, packetsDiscardedOnSend,
fecPacketsSent, bytesDiscardedOnSend,
averageRtcpInterval
remote-inbound-rtp sliCount, packetsRepaired, burstPacketsLost,
burstPacketsDiscarded, burstLossCount,
burstDiscardCount, burstLossRate,
burstDiscardRate, gapLossRate,
gapDiscardRate
remote-outbound-rtp sliCount, packetsDiscardedOnSend,
fecPacketsSent, bytesDiscardedOnSend
codec codecType
csrc the whole type

(2017->2022, we are getting closer)

@codecov

codecov Bot commented Oct 2, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.40%. Comparing base (019bb23) to head (7edbba6).
⚠️ Report is 6 commits behind head on next.

Additional details and impacted files
@@            Coverage Diff             @@
##             next    #3602      +/-   ##
==========================================
- Coverage   90.44%   90.40%   -0.04%     
==========================================
  Files          81       81              
  Lines        9221     9193      -28     
==========================================
- Hits         8340     8311      -29     
- Misses        881      882       +1     
Flag Coverage Δ
go 90.40% <ø> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@JoTurk JoTurk left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kcaffrey you made this PR recently to fix the SLI parser pion/rtcp#222 do you use SLIs? I think if yes, we shouldn't remove the stats, even if removed by w3c and libwebrtc

@fippo

fippo commented Oct 2, 2026

Copy link
Copy Markdown
Contributor Author

how is sliceLoss filled? I've never seen it useful for the way webrtc does video encoding

@fippo
fippo force-pushed the stats-remove-slicount branch from 2e94412 to bc6cabb Compare October 2, 2026 05:52
@kcaffrey

kcaffrey commented Oct 2, 2026

Copy link
Copy Markdown
Contributor

No, I don’t use SLIs. I was making some other edits to rtcp when I saw that bug and decided to fix it in its own PR (with the spirit of leaving things better than I found it).

Removes stats dropped by
  w3c/webrtc-stats#622
that were not populated by pion either:

| Type                | Removed                                       |
|---------------------|-----------------------------------------------|
| inbound-rtp         | sliCount, packetsRepaired, burstPacketsLost,  |
|                     | burstPacketsDiscarded, burstLossCount,        |
|                     | burstDiscardCount, burstLossRate,             |
|                     | burstDiscardRate, gapLossRate,                |
|                     | gapDiscardRate, averageRtcpInterval,          |
|                     | packetsFailedDecryption, packetsDuplicated    |
| outbound-rtp        | sliCount, packetsDiscardedOnSend,             |
|                     | fecPacketsSent, bytesDiscardedOnSend,         |
|                     | averageRtcpInterval                           |
| remote-inbound-rtp  | sliCount, packetsRepaired, burstPacketsLost,  |
|                     | burstPacketsDiscarded, burstLossCount,        |
|                     | burstDiscardCount, burstLossRate,             |
|                     | burstDiscardRate, gapLossRate,                |
|                     | gapDiscardRate                                |
| remote-outbound-rtp | sliCount, packetsDiscardedOnSend,             |
|                     | fecPacketsSent, bytesDiscardedOnSend          |
| codec               | codecType                                     |
| csrc                | the whole type                                |
@fippo
fippo force-pushed the stats-remove-slicount branch from bc6cabb to 7edbba6 Compare October 2, 2026 13:46
@fippo
fippo merged commit 58721ac into next Oct 2, 2026
23 of 24 checks passed
@fippo
fippo deleted the stats-remove-slicount branch October 2, 2026 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants