Skip to content

ci: enforce full mypy import checking - #279

Merged
pitill0 merged 1 commit into
mainfrom
ci/mypy-full-import-check
Oct 23, 2026
Merged

pitill0 merged 1 commit into
mainfrom
ci/mypy-full-import-check

Conversation

@pitill0

@pitill0 pitill0 commented Oct 23, 2026

Copy link
Copy Markdown
Owner

Summary

Strengthen FluxTuner's type-checking gate by removing --follow-imports=skip from both local and GitHub Actions mypy checks.

Changes

  • Update the Makefile gate to run mypy fluxtuner/.
  • Update the GitHub Actions quality job to use the same command.
  • Preserve the existing mypy configuration and explicit third-party import overrides.

Motivation

The previous gate allowed nine inherited mypy errors to remain undetected. Those errors were resolved in #278.

This change prevents the same import-skipping configuration from hiding similar errors in future development.

Validation

  • Official reinforced make gate: PASS
  • Pytest: 1,565 passed, 7 skipped
  • Mypy: 0 errors across 106 source files
  • Ruff format and lint: PASS
  • Python compilation and JavaScript syntax: PASS
  • pip-audit: no known vulnerabilities
  • Bandit: no issues identified

CI acceptance criteria

All quality jobs must pass on Python 3.11, 3.12 and 3.13, in addition to the existing Brynse contract, dependency audit and packaging jobs.

Scope

Two files changed, with no application code or dependency changes.

@pitill0 pitill0 self-assigned this Oct 23, 2026
@pitill0 pitill0 added the enhancement New feature or request label Oct 23, 2026
@pitill0
pitill0 merged commit 6ef28c5 into main Oct 23, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant