Repository navigation
ci: enforce full mypy import checking - #279
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Strengthen FluxTuner's type-checking gate by removing
--follow-imports=skipfrom both local and GitHub Actions mypy checks.Changes
mypy fluxtuner/.Motivation
The previous gate allowed nine inherited mypy errors to remain undetected. Those errors were resolved in #278.
This change prevents the same import-skipping configuration from hiding similar errors in future development.
Validation
make gate: PASSCI acceptance criteria
All quality jobs must pass on Python 3.11, 3.12 and 3.13, in addition to the existing Brynse contract, dependency audit and packaging jobs.
Scope
Two files changed, with no application code or dependency changes.