Conversation
added 2 commits
January 28, 2016 17:39
`tickCap` allows applications to specify a cap for tick values separately from the maxTick property. cleanup: - `timer.maxTick` can now be set to control the value of `maxTick` - `timer.debug` was broken and unused, now it is removed - global variable `ok` was removed - jsdoc strings added
| * - `100 ⟶ onTick(100)` | ||
| * - `120 ⟶ onTick(100)` | ||
| * - `9999 ⟶ onTick(100)` | ||
| * - `10000 ⟶ onTick(10000)` |
Contributor
There was a problem hiding this comment.
Was this supposed to be onTick(100) as well?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
tickCapallows applications to specify a cap for tick valuesseparately from the maxTick property.
cleanup:
timer.maxTickcan now be set to control the value ofmaxTicktimer.debugwas broken and unused, now it is removedokwas removed