Repository navigation
Conversation
Coverage reportClick to see where and how coverage changed
The report is truncated to 25 files out of 34. To see the full report, please visit the workflow summary page. This report was generated by python-coverage-comment-action |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
This reverts commit 6ca475d.
tjduigna
left a comment
There was a problem hiding this comment.
Thanks for the updates. Please address the existing-release update regression noted inline before merging. All required CI checks pass.
| _fetch_scalar( | ||
| connection, | ||
| "SELECT count(*) FROM entry_chains WHERE " | ||
| "chain_unresolved_fraction IS DISTINCT FROM " |
There was a problem hiding this comment.
[P2] Backfill chain completeness before validating updates to existing releases
Please backfill chain_unresolved_fraction for retained legacy rows before this check. The documented update_entries flow keeps old_rows.*: releases produced by the base revision lack this column, so removal-only updates fail here. With incoming rows, UNION ALL BY NAME fills the retained rows with null, which also fails this comparison. The weekly-update fixture now supplies the field, so passing CI does not cover this case. Derive the legacy value from the existing count/length columns, preserve validation of supplied values, and add a base-format removal-only regression test.
| ("chain_modified_residues", pa.list_(pa.string())), | ||
| ("chain_length", pa.int64()), | ||
| ("chain_num_unresolved_residues", pa.int64()), | ||
| ("chain_unresolved_fraction", pa.float64()), |
There was a problem hiding this comment.
[P2] Backfill chain completeness in targeted repairs
Please derive missing chain_unresolved_fraction values in repair_collation() before checking the installed chain schema. Releases produced by the base revision lack this column. Even with a regenerated replacement sidecar, a metadata-only repair now fails with ValueError: installed entry_chains does not have the current schema. I reproduced this by repairing chain modification annotations; the same repair succeeds on the base revision. The new backfill in update_entries._combine_tables() covers weekly updates, but targeted repairs bypass it. Apply the same derivation to the repair path, preserve validation of supplied values, and add a regression test with a base-format installed chain table.
tjduigna
left a comment
There was a problem hiding this comment.
Thanks for the fixes. Approving the code; required test and documentation checks still need to pass before merging.
Summary