docs: document the three-layer test structure in CLAUDE.md#174
Open
Gabrielpanga wants to merge 1 commit into
Open
docs: document the three-layer test structure in CLAUDE.md#174Gabrielpanga wants to merge 1 commit into
Gabrielpanga wants to merge 1 commit into
Conversation
This session added a real-sandbox integration suite (tests/integration/, run via `pnpm test:integration`) and a nock-based payments unit suite (tests/payments/), neither of which was described in CLAUDE.md. Document the unit/integration/shared split, the opt-in + auto-skip behaviour of the integration tests, where credentials come from (.env.test), and why the payments suite scopes nock.disableNetConnect locally. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Documents the test layout in
CLAUDE.md— a new Test structure subsection under Build and Test. This session introduced two test layers that weren't described anywhere in the knowledge base:tests/integration/— real-sandbox integration suite (pnpm test:integration, test: split integration suite by resource and tighten SDK/API contract #166)tests/payments/— nock-based unit coverage forPluggyPaymentsClient(test: add nock-based unit coverage for PluggyPaymentsClient #167)Why
The split is non-obvious and easy to trip over:
pnpm testignorestests/integration; the integration suite is opt-in viapnpm test:integration.PLUGGY_CLIENT_ID/PLUGGY_CLIENT_SECRETin.env.test, take ~30+ min, and auto-skip without creds.nock.disableNetConnect()intests/payments/utils.ts(not the shared setup) so the integration suite keeps live connections — a subtlety worth recording.Docs-only. No code changes.
🤖 Generated with Claude Code