Repository navigation
fix: address WP.org T4 review items (#228) - #230
Merged
Merged
Conversation
Two concrete code changes flagged in review R agentic-admin/schmitzoide/1Jun26/T4: - uploads-scan.php: resolve .well-known via get_home_path() instead of ABSPATH, which is wrong on subdirectory installs where the site root (document root) differs from the WordPress core directory. Guards the wp-admin/includes/file.php require so get_home_path() is available in the ability's REST load path. - vector-store.js: pin the Transformers.js jsDelivr URL to @3.8.1 (was floating @3). Matches indexing-worker.js and makes the readme changelog claim accurate — a privacy-first plugin should not depend on a CDN range that can ship new code without a deliberate bump. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Owner
|
This is exactly the two code items on the #228 plan, thanks for picking it up. Both changes check out against the tree:
Version correctly left at Agreed on parking the two decisions. I have put notes on both in #228, including the drafted reviewer reply, so they stay with the submission history: the remote-loading answer needs a framing change before it goes out, and the voy vendoring question is still open. Reminder for whoever merges: this does not go to the reviewer on its own. Zip upload and reply together, per the definition of done in #228. |
8 of 14 tasks
pluginslab
approved these changes
Aug 23, 2026
pluginslab
left a comment
Owner
There was a problem hiding this comment.
Verified against the tree. Both changes are correct and CI is green. Merging as step one of the #228 closeout.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses the two concrete code changes flagged in WP.org review
R agentic-admin/schmitzoide/1Jun26/T4, tracked in #228.Changes
uploads-scan.php— resolve the.well-knownscan path viaget_home_path()instead ofABSPATH. On subdirectory installs the site root (document root, where.well-knownlives) differs from the WordPress core directory, soABSPATH . '.well-known'scanned the wrong place. Guards thewp-admin/includes/file.phprequire soget_home_path()is available in the ability's REST load path.vector-store.js— pin the Transformers.js jsDelivr URL to@3.8.1(was floating@3). Now matchesindexing-worker.jsand makes the existing readme changelog claim accurate; a privacy-first plugin should not depend on a CDN range that can ship new code without a deliberate bump.Not in this PR (decisions in #228)
.module.wasm(item 2) — keeping the upstream reference for now; vendoring is the fallback if a T5 pushes back.Verification
composer lint/wp-scripts lint-jsclean on both filesnpm run buildcompiles0.11.0(submission is pinned there)Part of #228.
🤖 Generated with Claude Code