fix: resolve .jsx, .ts and .tsx block sources - #5
Open
thierrypigot wants to merge 1 commit into
Open
thierrypigot wants to merge 1 commit into
thierrypigot wants to merge 1 commit into
Conversation
The save, edit and variations parsers, and the block directory hash, only looked for save.js, edit.js and variations.js. Gutenberg renamed its JSX-bearing block sources to .jsx in WordPress/gutenberg#80990, so indexing Gutenberg trunk classified every core block as dynamic, with no verified example and no inspector control. Add resolveSourceFile(), which tries .js, .jsx, .ts then .tsx, and use it in the three parsers and in computeBlockDirHash(). Hashes of blocks that only ship .js files are unchanged, so existing indexes are not rebuilt.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The save, edit and variations parsers, and the block directory hash, only looked for save.js, edit.js and variations.js. Gutenberg renamed its JSX-bearing block sources to .jsx in WordPress/gutenberg#80990, so indexing Gutenberg trunk classified every core block as dynamic, with no verified example and no inspector control.
Add resolveSourceFile(), which tries .js, .jsx, .ts then .tsx, and use it in the three parsers and in computeBlockDirHash(). Hashes of blocks that only ship .js files are unchanged, so existing indexes are not rebuilt.