Repository navigation
A module can be one page, with no sidebar (#330) - #331
Merged
Merged
Conversation
A descriptor's 'layout' => 'page' draws the module as one page: no sidebar and no icon tab row. Its first tab is the page, 1040 wide like Home. Settings, reached by address, reads Saddle / Module / Settings and the module crumb leads back. A drill-in reads Saddle / Module / title. saddleShell.has( 'page-layout' ) tells a module; older Core ignores the key, and Rank and CRM keep the sidebar. Refs #330 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
main's committed bundle was older than its sources; this is the build of the sources on this branch. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
ifahimreza
marked this pull request as ready for review
October 5, 2026 00:41
ifahimreza
added a commit
that referenced
this pull request
Oct 5, 2026
Version in all five places (header, SADDLE_VERSION, stable tag, package.json, package-lock.json). The changelog adds the white sidebar panel (#329) beside the one-page layout (#331). saddle.pot regenerated: same 2,156 strings, new version and line numbers. Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #330
What
A module descriptor can say
'layout' => 'page'. Saddle then draws that module as one page: no sidebar and no icon tab row. Saddle Analytics uses it next (plan:planning/ANALYTICS-ONE-PAGE.md, P1). Rank and CRM keep the sidebar.How
Saddle_Modules::modules()keepslayoutaspageorsections, the default. Anything else becomessections, and every Core page issections. The admin app gets it with each area.frameHeader()): the first tab is the page, 1040 wide like Home. Any other tab (Settings, reached by address) readsSaddle / Module / Settings, 920 wide, and the module crumb leads back. A drill-in readsSaddle / Module / title, with no section crumb.saddleShell.has( 'page-layout' ).admin/build.main's committed bundle was older than its sources; the main checkout carries the same uncommitted rebuild.Testing
frameHeadercases for a one-page module.wp-scripts lint-jsclean on the changed files; phpcs clean onincludes/.Saddle / Analytics / Settings, has no sidebar, and its Analytics crumb leads back; no script errors. Rank and CRM descriptors are untouched (nolayout), so they keep the sidebar.🤖 Generated with Claude Code
Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.