Repository navigation
Docs: what the GROMACS interfaces support, in the master manual - #1507
Conversation
|
@invemichele-peptone I am removing gromacs 2022 and 2023 patches from master, could you please update this to remove them here as well? |
|
ok, I'll tell Claude about it :) |
9c60c46 to
a98461c
Compare
|
@carlocamilloni done: rebased on 6f73c1b, with the parts for GROMACS 2022 and 2023 dropped from all commits and the docs table now saying "patch for GROMACS 2024". Since #1505 and #1506 were merged while I was still running a last review, this also includes the fixes I found then, which are in two small follow-ups: #1508 (v2.9) and #1509 (v2.10). The description is updated. 🤖 Generated with Claude Code |
A table in the list of MD codes of the master manual compares the PLUMED module of GROMACS 2025 and later with the patches for GROMACS 2025/2026 and for GROMACS 2024 (ENERGY, multiple simulations through MPI, checkpoints, stop requests, shells, replica exchange, lambda dynamics), as tested by the regression tests of the PLUMED testcenter, with notes on the limitations. It replaces the sentence that suggested the patch for GROMACS 2025/2026 for replica exchange and lambda dynamics, which only the patch for GROMACS 2024 has. v2.10 has the same table in user-doc/Introduction.md (plumed#1506, plumed#1509). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
a98461c to
ac28727
Compare
|
@carlocamilloni I see that you merged v2.10 into master, which brought #1505 and #1506 here: I checked that the GROMACS patches and the kernel fixes in master are now the same as in v2.10. So I reduced this PR to the only part that cannot come from v2.10: the table of the GROMACS interfaces in the master manual. The follow-ups #1508 and #1509 can reach master with the next merge of v2.10, without conflicts. 🤖 Generated with Claude Code |
Description
This PR was the port of #1505 and #1506 to master. These have now reached master with the merge of v2.10 (e879e3a): I checked that the 2024.3, 2025.0 and 2026.0 patches and the kernel fixes in master are the same as in v2.10, apart from
PLUMED_LOG_FILEin the 2025 patch. Their follow-ups, #1508 (v2.9) and #1509 (v2.10), can reach master in the same way. A port here would only duplicate them, and conflict with the next merge.So what is left is the part of the documentation that only master has: the table of what the GROMACS interfaces support, in
new-manual/mdcodes.md. v2.10 has the same table inuser-doc/Introduction.md(#1506, with the notes of #1509).WALKERS_MPI)-replex,-hrex)GMX_DISABLE_MODULAR_SIMULATOR=1.The table replaces the sentence that suggested the patch for GROMACS 2025/2026 for replica exchange and lambda dynamics, which only the patch for GROMACS 2024 has. The cells follow the regression tests proposed to the PLUMED testcenter in plumed-testcenter/plumed-testcenter#95.
The CHANGES entries that came from v2.9 and v2.10 use
\ref, which the master manual shows verbatim. I left them as they are: converting them here would conflict with the next merges of v2.10. The same holds for older entries.Target release
I would like my code to appear in release v2.11
Type of contribution
Copyright
COPYRIGHTfile with the correct license information. Code should be released under an open source license. I also used the commandcd src && ./header.sh mymodulenamein order to make sure the headers of the module are correct.Tests
🤖 Generated with Claude Code