Repository navigation
configure: do not look for python3 when python is disabled - #1514
Merged
Merged
Conversation
--disable-python still triggered the python3 search (printing "checking for python3..." and a spurious "cannot enable python interface" warning). Only search for python3 when the python interface is actually enabled. The resulting configuration is unchanged: without python support PYTHON_BIN was already reset to empty at the end of the block. Fixes plumed#1422
Contributor
Author
|
The only failing check is |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1422.
With
--disable-python, configure still ranAC_CHECK_PROGS([PYTHON_BIN],[python3]), printingchecking for python3...and then a spuriouscannot enable python interfacewarning, even though no python support would be built.Only search for python3 when the python interface is enabled. The resulting configuration is unchanged: without python support,
PYTHON_BINwas already reset to empty at the end of the block (sopython_bininMakefile.confis empty either way, and the python bindings build insrc/lib/Makefileis guarded byifdef python_bin).Changes:
configure.ac: gate theAC_CHECK_PROGScall ontest "$python" = true.configure: the same edit applied to the generated script (as usual for this repository).Verification:
python=falsethe search is skipped andPYTHON_BINstays empty; withpython=truethe search still runs and finds python3 as before.bash -n configurepasses.PYTHON_BINempty when python is disabled).