Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions .github/workflows/npm-publish.yml
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,11 @@ jobs:
(github.event.workflow_run.conclusion == 'success'
&& github.event.workflow_run.head_branch == 'master'
&& github.event.workflow_run.event == 'push')
runs-on: self-hosted
# GitHub-hosted: the org's self-hosted runner group does not accept jobs
# from public repos, so `self-hosted` could never be scheduled here.
# Auth is OIDC trusted publishing (id-token above), which works from
# GitHub-hosted runners without any runner-local credentials.
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v6
with:
Expand All @@ -54,8 +58,9 @@ jobs:
cache-dependency-path: |
package-lock.json

# Pinned: org standard is npm 12 (matches shared-actions validate-codebase). Bump deliberately.
- name: Update npm
run: npm install -g npm@latest
run: npm install -g npm@12.0.2

- name: Install dependencies
run: npm ci
Expand Down
24 changes: 18 additions & 6 deletions .github/workflows/validate.yml
Original file line number Diff line number Diff line change
Expand Up @@ -18,8 +18,9 @@ jobs:
# Push events (merge to master) always validate — that run is what gates
# publishing. PR events only run when the PR's head branch lives in THIS
# repo (which requires write access); PRs from forks have a different head
# repo and skip the job, so untrusted fork code never reaches the
# self-hosted runner.
# repo and skip the job. On the ephemeral GitHub-hosted runner below this
# is a POLICY choice, not a runner-safety requirement (fork runs are
# sandboxed and get no secrets) — drop the `if` to give fork PRs CI.
#
# We gate on head-repo identity rather than author_association because the
# latter downgrades private org members to "CONTRIBUTOR" in the event
Expand All @@ -34,7 +35,11 @@ jobs:
if: >-
github.event_name != 'pull_request' ||
github.event.pull_request.head.repo.full_name == github.repository
runs-on: self-hosted
# GitHub-hosted: the org's self-hosted runner group does not accept jobs
# from public repos (allows_public_repositories=false, on purpose — it
# keeps fork PRs off the fleet), so `self-hosted` here could never be
# scheduled. Nothing below depends on runner-local state.
runs-on: ubuntu-latest
steps:
# Up-front checkout: required so the local composite actions
# (./.github/actions/*) exist on the runner before they're referenced,
Expand All @@ -45,9 +50,16 @@ jobs:
with:
fetch-depth: 2

# Env check: fail fast if the runner's Node/npm majors don't match what
# the repo expects (NODE_MAJOR_VERSION / NPM_MAJOR_VERSION are pncit
# org-level Actions variables).
# Install the repo's Node (.nvmrc) before the toolchain check: the hosted
# image's system Node is whatever Ubuntu ships, not necessarily ours.
# validate-codebase below runs setup-node again; that's a cache hit.
- uses: actions/setup-node@v6
with:
node-version-file: .nvmrc

# Env check: fail fast if the Node/npm majors don't match what the repo
# expects (NODE_MAJOR_VERSION / NPM_MAJOR_VERSION are pncit org-level
# Actions variables). Also catches .nvmrc drifting from the org standard.
- uses: ./.github/actions/verify-node-toolchain
with:
node-major-version: ${{ vars.NODE_MAJOR_VERSION }}
Expand Down
4 changes: 2 additions & 2 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@pncit/node-quickbooks",
"version": "2.0.52",
"version": "2.0.53",
"description": "node.js client for Intuit's IPP QuickBooks V3 API.",
"main": "index.js",
"types": "index.d.ts",
Expand Down