ci: shared-actions v3.1.0 — a skipped install script fails validate - #23
Merged
Merged
Conversation
pncit/shared-actions#35: the `Audit skipped install scripts` step in validate-codebase is now fatal. This repo declares `allowScripts` (pncit/.github#24), so nothing changes today; from here a dependency bump that brings a new or re-versioned install script reds `validate` with the fix in the error text instead of scrolling past as a warning. CI-only change (.github/** is exempt from the version-bump gate).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes out pncit/.github#24 for this repo: pins shared-actions to v3.1.0 (
4281e5b), whose only change is pncit/shared-actions#35 — theAudit skipped install scriptsstep invalidate-codebasegoes from::warning::to a failed job.Nothing changes for this repo today: its
allowScriptsis already complete and its lastvalidaterun had a silent audit step. What changes is the next time a dependency bump brings a new or re-versioned install script:validategoes red with the offendingnpm warn install-scripts <pkg>@<ver>line and the fix in the error text (npx npm@12.0.2 install-scripts ls, thenapprove <pkg>/deny <pkg>, commitpackage.json).esbuildis approved unpinned so its bumps do not trip this.Public repos: the vendored copies under
.github/actions/are re-copied byte-for-byte from v3.1.0 with the banner updated.CI-only (
.github/**is exempt fromverify-version-bump) — no version bump, no publish.