Repository navigation
fix(network): report unsupported tx types via Err instead of panicking - #319
Open
HusseinAdeiza wants to merge 1 commit into
Open
HusseinAdeiza wants to merge 1 commit into
HusseinAdeiza wants to merge 1 commit into
Conversation
complete_type() hit unimplemented!() for any TxType other than EIP-1559, which panics the caller's thread. The trait's signature already returns Result<(), Vec<&'static str>>, so unsupported types now report through the Err path like every other validation failure.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
PodTransactionRequest::complete_type()hitunimplemented!()for anyTxTypeother than EIP-1559, which panics the caller's thread. The trait signature already returnsResult<(), Vec<&'static str>>, so unsupported transaction types now report through theErrpath — consistent with how every other validation failure in the builder is surfaced.No behavior changes for EIP-1559 (the only previously working path).