Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
47 changes: 14 additions & 33 deletions src/providers/google-vertex-ai/chatComplete.ts
Original file line number Diff line number Diff line change
Expand Up @@ -261,39 +261,20 @@ export const VertexGoogleChatCompleteConfig: ProviderConfig = {
)
)
return;
const firstMessage = params.messages?.[0] || null;
if (!firstMessage) return;

if (
SYSTEM_MESSAGE_ROLES.includes(firstMessage.role) &&
typeof firstMessage.content === "string"
) {
return {
parts: [
{
text: firstMessage.content,
},
],
role: "system",
};
}

if (
SYSTEM_MESSAGE_ROLES.includes(firstMessage.role) &&
typeof firstMessage.content === "object" &&
firstMessage.content?.[0]?.text
) {
return {
parts: [
{
text: firstMessage.content?.[0].text,
},
],
role: "system",
};
}

return;
// contents skips every system message, so all of them go here.
const parts = (params.messages ?? [])
.filter((message) =>
SYSTEM_MESSAGE_ROLES.includes(message.role),
)
.flatMap((message) =>
typeof message.content === "string"
? [{ text: message.content }]
: (message.content ?? [])
.filter((part) => part.text)
.map((part) => ({ text: part.text })),
);
if (!parts.length) return;
return { parts, role: "system" };
},
},
],
Expand Down
34 changes: 33 additions & 1 deletion tests/unit/src/services/transformToProviderRequest.node.ts
Original file line number Diff line number Diff line change
@@ -1,6 +1,11 @@
import assert from 'node:assert/strict';
import { describe, it } from 'node:test';
import { AZURE_OPEN_AI, BEDROCK, OPEN_AI } from '../../../../src/globals';
import {
AZURE_OPEN_AI,
BEDROCK,
GOOGLE_VERTEX_AI,
OPEN_AI,
} from '../../../../src/globals';
import { BedrockConverseAnthropicChatCompletionsParams } from '../../../../src/providers/bedrock/chatComplete';
import { Params } from '../../../../src/types/requestBody';
import { transformToProviderRequest } from '../../../../src/services/transformToProviderRequest';
Expand Down Expand Up @@ -153,3 +158,30 @@ describe('Claude Converse parameters', () => {
assert.equal('additionalModelRequestFields' in request, false);
});
});

describe('Vertex Gemini system messages', () => {
it('sends every system message and text part as systemInstruction', () => {
const request = chatRequest(GOOGLE_VERTEX_AI, {
model: 'gemini-3-flash-preview',
messages: [
{ role: 'system', content: 'Answer in German.' },
{
role: 'system',
content: [
{ type: 'text', text: 'Be brief.' },
{ type: 'text', text: 'End with BANANE.' },
],
},
{ role: 'user', content: 'Name a colour.' },
],
});
assert.deepEqual(request.systemInstruction, {
parts: [
{ text: 'Answer in German.' },
{ text: 'Be brief.' },
{ text: 'End with BANANE.' },
],
role: 'system',
});
});
});
Loading