Repository navigation
Add campaign segment and drip sequence commands - #81
Conversation
|
Warning Review limit reachedThe included review limit has been reached and this organization has disabled usage-based review continuation. Wait for reviews to reset or ask a billing admin to change After included review limits.
Reviews can continue after your included limit without a manual trigger. An admin must approve usage-based billing. Next included review available in 14 minutes. View limit details
Comment |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 02b1f219cd
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Summary
Refresh segments/drip against CLI main
f1ecd8deea(merged #80) and API dev9bb1e2e, without rebasing. Both cap/drip flag sets, recipient reasons and analytics coexist. Create now rejects--remove-dripbefore HTTP; removal remains available through update for an existing unlaunched draft.SDK pin remains
0.1.0-dev.20261004024706; local types/authenticated raw transport bridge unpublished methods. Platform composed content uses project ID; Messaging settings use project slug. PATCH preserves omitted drip fields and writes are sent once.Impact
Impact table
0.1.0-dev.20261004024706; local types/authenticated raw transport bridge missing methods. TS/Go/Python/PHP/C#/Rust package parity and acceptance remain separate SDK work (#348/#350/#351/#352).No impact table
9bb1e2e; no routes, scopes, protocol, workflow or storage changes.Verification
Node 24:
npm run verifypasses (1,087 tests / 112 files, format, lint, typecheck, build, pack dry-run, zero production audit vulnerabilities). Three release-evidence tests and Actionlint pass. Focused 49-test suite covers combined segment/drip/cap commands, both PATCH routes, close-only omissions, 503 no-retry behavior, analytics, and inline cap conflicts. New checks reject--remove-dripon create with zero HTTP for both selectors, retain update removal, and preserve valid team-only cap selection on create. Paths/scopes/revisions and fields checked against dev9bb1e2especs and route authority. No deployed API, real send, hosted enrollment, registry install or publication exercised.Session provenance and UI evidence
Parent thread
646a0c0a-e900-4d0f-9a25-0b8834d7d4e6; implementation agent gpt-6.1-sol through T3 Code. Sequential work, no requested automated reviews. Coordinator owns registration/checkpoint publication; that evidence is pending. Synthetic terminal/HTTP fixtures only; no GUI changes or screenshots.Rollout and rollback
Orchestrator owns merging. All PRs target main per
RELEASING.md. Main push runs CI, not publication.publish-dev.ymlruns at 02:30 UTC or manually and selects an exact registry SDK in disposable build inputs, requiring matching staging acceptance for nightly or production for stable. The existingcontracts/abprops-capabilities.jsonhaspublished: false, which independently blocks the publication gate. Merging source does not publish or prove availability. No workflow changes. Revert client changes before publication; published fixes need a new package. No migrations or flag changes.Dependency #80 is merged and main is integrated; #79 remains independent with filters gated. SDK #352 source merge does not establish an accepted registry package.