Skip to content

Use Number-scoped test phone and event routes - #359

Draft
purpshell wants to merge 2 commits into
mainfrom
codex/test-number-dropin-routes-main
Draft

purpshell wants to merge 2 commits into
mainfrom
codex/test-number-dropin-routes-main

Conversation

@purpshell

@purpshell purpshell commented Oct 19, 2026 •

Copy link
Copy Markdown
Member

Summary

Test phone and event methods address a Number directly, matching the API cutover in polymorfa/polymorfa#792. getPhone, sendPhoneMessage and unlinkPhoneDevice drop the project argument; triggerEvent(numberId, body) removes body session and uses optional fromNumber; listEventFixtures() takes no project. History uploads keep project scope at /messaging/projects/{projectId}/test-history-fixtures. No aliases or redirects are used.

Keep sandbox:read / sandbox:write. API dependency: polymorfa/polymorfa#792, currently stacked on #647. Exact six-route source pin remains 79e62733b1b3d523618232a3794e26df64b7f486. No old public /messaging/sandbox/* consumer exists in this repository.

Impact

Impact table

Area Updated / blocked Change or blocker Evidence
SDKS Updated TypeScript server methods, request types, wire tests, README and unreleased changelog; exact six-operation API pin and global coverage reconciliation. Reviewed snapshot hash and exact summary repaired without relaxing baseline/hash/no-supplements guards. Source, tests, contracts and README in this PR
API and companion client Blocked on coordinated merge Number-scoped API precedes release; SDK/CLI drafts remain coordinated. CLI uses released SDK raw transport. polymorfa/polymorfa#792, #359, polymorfa/cli#88
Public docs, Help Center, roadmap Blocked Frozen public MDX and docs app belong to #783. Help Center/Linear/Notion inaccessible in this child; no synchronization claimed. API docs handoff in #792
Release Blocked on acceptance No package publication, deployed API availability or installed-client acceptance claimed. API release record in #792

No impact table

Area Why there is no impact Evidence
Libraries, runners/Bartender, Temporal, Admin API/MCP/UI, Logs/audit, billing/PAYG, Usage, Analytics and consented tracking Client path/contract changes introduce no protocol, storage, staff grant, metering or tracking behavior. Diff is client/contracts/docs/tests; API implementation owned by #792
Inspector, Console UI and onboarding controls Private/native consumers do not call removed public pool routes; no UI controls change here. #792 legacy consumer inventory; existing Test-number creation unchanged
Flags, entitlements and sandbox scopes Existing Test-number beta authority and exact scope strings remain. No configuration/flag/migration edits
Other SDK packages/languages This route surface is owned by the TypeScript server SDK; other packages do not expose these methods. SDK coverage ledger and source inventory

Verification

Exact head 312d0d4179efabded172ae8a5fbbf2ada0e2a33d contains current main d2c5b3dfe4b13dee6d7a07b96df213e47ef8130a (ancestor check passed). Natural pull-request CI run 39563056076 succeeded on this exact head using GitHub-hosted ubuntu-latest, runner group GitHub Actions (Node 20 and 22). No workflow dispatch or review request.

Local Node 22 checks: 1,542 tests in 146 files; 7 release/coverage gate tests; workspace builds, format, lint, typecheck, strict 582 total / 442 covered / 140 excluded / 0 missing, partial or changed; package dry runs; zero production audit vulnerabilities. The prior failed natural run is superseded by this source fix and successful run. Browser, attended/provider, deployed API and package acceptance were not exercised overnight.

Session provenance and UI evidence

Registration: polymorfa/polymorfa#511 (purpshell-t3-codex). This app-owned child was absent from the local recorder SQLite projection; no successful transcript checkpoint is claimed. Sanitized consumer/verification receipt is in #792's local follow-up commit 82843c052072994e00c120a52ccfb6a4ae98c893, pending the dependency push gate. No UI implementation changed; screenshots are not applicable.

Rollout and rollback

Keep this draft main-based. Land API #792 after #647 and qualified-dev integration, then coordinate SDK/CLI integration, publication and matching staging/production acceptance separately. No package publication or environment release is authorized here. No migration, flag, scope rename or queued-work format changes. Revert this PR to roll back client behavior. Preserve actual review/security gates; draft-skipped bot output is not review clearance.

@coderabbitai

coderabbitai Bot commented Oct 19, 2026

Copy link
Copy Markdown

Important

Draft PR not reviewed

Draft PRs are not automatically reviewed by default.

  • Trigger a manual review

To automatically review draft PRs, update your CodeRabbit configuration:

reviews:
  auto_review:
    drafts: true
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Comment @coderabbitai help to get the list of available commands.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant