Repository navigation
Conversation
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: true
Comment |
This was referenced Oct 21, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test phone and event methods address a Number directly, matching the API cutover in polymorfa/polymorfa#792.
getPhone,sendPhoneMessageandunlinkPhoneDevicedrop the project argument;triggerEvent(numberId, body)removes bodysessionand uses optionalfromNumber;listEventFixtures()takes no project. History uploads keep project scope at/messaging/projects/{projectId}/test-history-fixtures. No aliases or redirects are used.Keep
sandbox:read/sandbox:write. API dependency: polymorfa/polymorfa#792, currently stacked on #647. Exact six-route source pin remains79e62733b1b3d523618232a3794e26df64b7f486. No old public/messaging/sandbox/*consumer exists in this repository.Impact
Impact table
No impact table
Verification
Exact head
312d0d4179efabded172ae8a5fbbf2ada0e2a33dcontains currentmaind2c5b3dfe4b13dee6d7a07b96df213e47ef8130a(ancestor check passed). Natural pull-request CI run 39563056076 succeeded on this exact head using GitHub-hostedubuntu-latest, runner groupGitHub Actions(Node 20 and 22). No workflow dispatch or review request.Local Node 22 checks: 1,542 tests in 146 files; 7 release/coverage gate tests; workspace builds, format, lint, typecheck, strict 582 total / 442 covered / 140 excluded / 0 missing, partial or changed; package dry runs; zero production audit vulnerabilities. The prior failed natural run is superseded by this source fix and successful run. Browser, attended/provider, deployed API and package acceptance were not exercised overnight.
Session provenance and UI evidence
Registration: polymorfa/polymorfa#511 (
purpshell-t3-codex). This app-owned child was absent from the local recorder SQLite projection; no successful transcript checkpoint is claimed. Sanitized consumer/verification receipt is in #792's local follow-up commit82843c052072994e00c120a52ccfb6a4ae98c893, pending the dependency push gate. No UI implementation changed; screenshots are not applicable.Rollout and rollback
Keep this draft main-based. Land API #792 after #647 and qualified-dev integration, then coordinate SDK/CLI integration, publication and matching staging/production acceptance separately. No package publication or environment release is authorized here. No migration, flag, scope rename or queued-work format changes. Revert this PR to roll back client behavior. Preserve actual review/security gates; draft-skipped bot output is not review clearance.