Repository navigation
Fix trailing MSSQL GO batch separators - #69
Merged
melonamin merged 2 commits intoSep 24, 2026
Merged
Conversation
dvasdekis
marked this pull request as ready for review
September 1, 2026 04:49
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Addresses #68. The MSSQL
GOsplitter left a trailing separator as a standalone SQL range when it overlapped a semicolon-delimited range. The parser then reportedPARSE_ERRORfor a valid batch script.The splitter now clips overlapping
GOlines to each statement range. Intermediate, repeated, leading, and trailing separators remain batch boundaries.Changes
GOseparators, plusGOinside strings, comments, and bracket-quoted identifiers.GOseparates batches.GO, preserving source names, statement indexes, and spans.Validation
just checkpassed, including Rust and TypeScript tests, lint, formatting, typechecks, and schema checks.cargo test -p flowscope-core mssql_ --lockedpassed.cargo test -p flowscope-cli --test mssql_go_cli --lockedpassed.cargo test -p flowscope-wasm --test analysis --lockedpassed.just build-wasmpassed. The browser harness passed against the optimized WASM artifact: two MSSQL statements, noPARSE_ERROR.@pondpilot/flowscope-coretarball passed the reproduction from Release and verify MSSQL GO batch support in the published npm/WASM package #68: two statements, noPARSE_ERROR.The CI workflow builds WASM but does not currently invoke the browser harness. Adding that CI step requires a GitHub token with
workflowscope.Publishing and checking the upstream npm package remain part of #68.