Skip to content

Scope SQLite control argument lifetime #37

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
simolus3 merged 2 commits into from
Sep 16, 2026
Merged

Scope SQLite control argument lifetime #37

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2250db3
fix(sync): copy dynamic SQLite control arguments
birdmanmandbir Sep 16, 2026
b0c1606
fix(sync): scope SQLite control argument lifetime
birdmanmandbir Sep 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 11 additions & 6 deletions powersync/src/sync/download/sync_iteration.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -193,17 +193,21 @@ impl DownloadEvent {
let (op, arg) = self.into_powersync_control_argument();

stmt.bind_text(1, op, Destructor::STATIC)?;
arg.bind_to(&stmt, 2)?;
// SAFETY: `arg` remains alive until after `stmt` is explicitly dropped below.
unsafe { arg.bind_to(&stmt, 2)? };

if let ResultCode::ROW = stmt.step()? {
let instructions = if let ResultCode::ROW = stmt.step()? {
let instructions = stmt.column_text(0).map_err(|_| {
PowerSyncError::argument_error("Could not read powersync_control instructions")
})?;

serde_json::from_str(instructions)?
} else {
panic!("Expected a row") // Can't happen, scalar select
}
};

drop(stmt);
instructions
};

tx.commit()?;
Expand All @@ -219,9 +223,10 @@ enum PowerSyncControlArgument {
}

impl PowerSyncControlArgument {
fn bind_to(&self, stmt: &ManagedStmt, index: i32) -> Result<(), ResultCode> {
// We use Destructor::STATIC here which is technically not safe, but fine since we'll always
// drop the statement before the control argument.
/// # Safety
///
/// The argument must outlive `stmt`.
unsafe fn bind_to(&self, stmt: &ManagedStmt, index: i32) -> Result<(), ResultCode> {
match self {
PowerSyncControlArgument::Null => stmt.bind_null(index),
PowerSyncControlArgument::StaticString(str) => {
Expand Down
Loading