Repository navigation
fix(core): dispose effects when model factory throws - #987
Open
SisyphusZheng wants to merge 2 commits into
Open
SisyphusZheng wants to merge 2 commits into
SisyphusZheng wants to merge 2 commits into
Conversation
Implementation and regression tests assisted by OpenAI Codex.
🦋 Changeset detectedLatest commit: f0785ab The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
✅ Deploy Preview for preact-signals-demo ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #986
Summary
Dispose captured effects when a
createModelfactory throws. Previously, the error handler cleared the capture list without cancelling subscriptions or running cleanup callbacks.Disposal is batched so cleanup writes do not rerun effects awaiting disposal. If a cleanup throws, remaining effects are still disposed and the original factory error is preserved.
Testing
useModeltests: 181 passed, 2 skipped.AI assistance
This contribution was developed with assistance from AI.