Support Babel 8 in the signals transforms - #990
Merged
Merged
Conversation
Widen the @babel/core peer range of react-transform and preact-transform to ^7.0.0 || ^8.0.0 and run both transform test suites against Babel 8 in an extra vitest project. Closes #989
🦋 Changeset detectedLatest commit: 5c0df22 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
✅ Deploy Preview for preact-signals-demo ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Contributor
|
Size Change: 0 B Total Size: 199 kB ℹ️ View Unchanged
|
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #989
Both transforms already work on Babel 8 unchanged. Only the
@babel/corepeer range (^7.0.0) was blocking them; npm fails withERESOLVE.^7.0.0 || ^8.0.0inreact-transformandpreact-transform.babel-8vitest project that aliases@babel/coreto Babel 8 and reruns both transform suites (871 tests, all passing).transformSync(Babel 8'stransformis callback-only) andparserOpts: { plugins: ["jsx"] }in place of the syntax plugin, so the same harness runs on both versions.@babel/core@^7inextension. Without the pin, pnpm resolves@preact/preset-vite's auto-installed peer to Babel 8.